Add Hardware Home page#1456
Open
lordbagel42 wants to merge 7 commits into
Open
Conversation
Contributor
Greptile SummaryThis PR adds a new
Confidence Score: 4/5Safe to merge functionally, but the hardware page will always advertise itself to search engines and social platforms as a coding tracker, directly working against the page's purpose. The controller reuses set_homepage_seo_content unchanged, so every visit to /hardware sends coding-focused title, og:title, and meta description tags — the wrong metadata for a page explicitly targeting hardware makers. app/controllers/static_pages_controller.rb — the hardware action needs its own SEO content method rather than sharing the one written for the coding homepage. Important Files Changed
Sequence Diagram%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
participant Browser
participant Router as Rails Router
participant Controller as StaticPagesController
participant Cache as Cache::HomeStatsJob
participant Inertia
Browser->>Router: GET /hardware
Router->>Controller: hardware()
alt current_user present
Controller-->>Browser: redirect_to root_path
else guest
Controller->>Controller: set_homepage_seo_content()
Note over Controller: Sets coding-focused SEO tags
Controller->>Cache: perform_now
Cache-->>Controller: home_stats
Controller->>Inertia: render HardwareHome/SignedOut
Inertia-->>Browser: HTML + props
end
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
participant Browser
participant Router as Rails Router
participant Controller as StaticPagesController
participant Cache as Cache::HomeStatsJob
participant Inertia
Browser->>Router: GET /hardware
Router->>Controller: hardware()
alt current_user present
Controller-->>Browser: redirect_to root_path
else guest
Controller->>Controller: set_homepage_seo_content()
Note over Controller: Sets coding-focused SEO tags
Controller->>Cache: perform_now
Cache-->>Controller: home_stats
Controller->>Inertia: render HardwareHome/SignedOut
Inertia-->>Browser: HTML + props
end
Reviews (2): Last reviewed commit: "Merge branch 'main' into hardware-home" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
moved commits over from #1454. Current homepage is unfriendly to new hardware users, this PR adds a more friendly version of it at hackatime.hackclub.com/hardware